linux-kernel - Re: [PATCH 3/6] x86/platform/uv/BAU: Add wait_completion to bau

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1702161908240.3543@nanos>
Date:   Thu, 16 Feb 2017 19:11:36 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Andrew Banman <abanman@....com>
cc:     mingo@...hat.com, akpm@...ux-foundation.org, hpa@...or.com,
        mike.travis@....com, rja@....com, sivanich@....com, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] x86/platform/uv/BAU: Add wait_completion to
 bau_operations

On Tue, 14 Feb 2017, Andrew Banman wrote:

> Remove the present wait_completion routine and add a function pointer by
> the same name to the bau_operations struct. Rather than switching on the
> UV hub version during message processing, set the architecture-specific
> uv*_wait_completion during initialization.

Well written changelog!


> +static int uv1_wait_completion(struct bau_desc *bau_desc,
> +				struct bau_control *bcp, long try);
> +static int uv2_3_wait_completion(struct bau_desc *bau_desc,
> +				struct bau_control *bcp, long try);

You could spare the forward declarations by moving the uv*_bau_ops down
right before uv_bau_init(). And while at it, the uv*_bau_ops can be made
__initconst.

>  static struct bau_operations ops;

That one can be made __ro_after_init as the only possible modification
happens in the init function.

Thanks,

	tglx