linux-kernel - Re: [PATCH v2 1/9] staging: rtl8192u: fixing white space issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170216183435.GA5486@kroah.com>
Date:   Thu, 16 Feb 2017 10:34:35 -0800
From:   Greg KH <gregkh@...uxfoundation.org>
To:     simran singhal <singhalsimran0@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/9] staging: rtl8192u: fixing white space issue

On Wed, Feb 15, 2017 at 01:37:13AM +0530, simran singhal wrote:
> Fix the following checkpatch.pl error and warnings:
> WARNING: please, no space before tabs
> 
> Signed-off-by: simran singhal <singhalsimran0@...il.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> index 873969c..a54dfad 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> @@ -30,7 +30,7 @@ typedef struct _TX_TS_RECORD{
>  	u16				TxCurSeq;
>  	BA_RECORD			TxPendingBARecord;	/*  For BA Originator */
>  	BA_RECORD			TxAdmittedBARecord;	/*  For BA Originator */
> -/* 	QOS_DL_RECORD		DLRecord; */
> +/*	QOS_DL_RECORD	DLRecord; */

Why did you change the number of tabs here?

Also, just delete unused fields, why keep them around?

thanks,

greg k-h