linux-kernel - Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALrZqyNbfKXcTjt54Ffp+QbdTcOjZRgwzj50nq_iOCJN7hx9Dw@mail.gmail.com>
Date:   Fri, 17 Feb 2017 00:38:48 +0530
From:   SIMRAN SINGHAL <singhalsimran0@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Joe Perches <joe@...ches.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

I didn't mean what you get. I just want to say I am a beginner and like to
contribute to Linux kernel. But at present, I am in learning mode.

I never mean that I am doing this for learning C or C++ but yes for
contributing to
Linux kernel in every possible way.

And, would be very happy if you guide me so that I can improve.




On Fri, Feb 17, 2017 at 12:02 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Wed, Feb 15, 2017 at 01:48:13PM +0530, SIMRAN SINGHAL wrote:
>> On Wed, Feb 15, 2017 at 9:01 AM, Joe Perches <joe@...ches.com> wrote:
>> > On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote:
>> >> Yes, I totally agree with joe.
>> >>
>> >> But as there is no coding style issue in this patch.
>> >
>> > Style is more than just checkpatch conformity.
>> >
>> >> So, do I have to resend the complete patch series again?
>> >
>> > I'm not applying any of these so that's entirely up
>> > to Greg.
>> >
>> > Perhaps he might apply the first 5 patches and reject
>> > this one, maybe he might apply all the patches.
>> >
>> > In any case, do strive to develop some reasonable
>> > semblance of style and do more than just checkpatch
>> > suggested patches and find and fix some actual defect
>> > somewhere.
>>
>> Joe, I am new to Linux kernel and just have basic knowledge of
>>  C and C++.
>
> As Joe said, the kernel is _not_ the project to learn C with.  Please
> get some more experience with userspace programs in C first, before
> working on the kernel.  It will be much easier for you.
>
> thanks,
>
> greg k-h