linux-kernel - Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tw7t4zss.fsf@linux.intel.com>
Date:   Thu, 16 Feb 2017 22:59:47 +0200
From:   Felipe Balbi <felipe.balbi@...ux.intel.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Oliver Neukum <oneukum@...e.com>
Cc:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        thomas@...ischhofer.net, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code


Hi,

Greg KH <gregkh@...uxfoundation.org> writes:
> On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote:
>> Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva:
>> > The condition modex % 16 cannot be true when modex value is equal to
>> > 640
>> > The condition du & 0xff cannot be true when du value is equal to
>> > 0x1400
>> > 
>> 
>> Sorry for speaking up so late, but this is not a good idea.
>> We lose the knowledge how to do this correctly, if we want
>> to change the resolution.
>
> Given the age of this driver, I doubt that will ever happen :)

besides, the "knowledge" will always be in git history.

-- 
balbi