linux-kernel - Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Feb 2017 23:11:37 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Michał Kępień <kernel@...pniu.pl>,
        Alex Hung <alex.hung@...onical.com>,
        Pavel Machek <pavel@....cz>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Anthony Wong <anthony.wong@...onical.com>,
        Richard Purdie <rpurdie@...ys.net>,
        Pali Rohár <pali.rohar@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

Hi Michał,

On 02/16/2017 12:32 PM, Michał Kępień wrote:
>> The led stops working after 4th patch "platform/x86: dell-laptop:
>> import dell_micmute_led_set() from drivers/leds/dell-led.c", and the
>> .config is with CONFIG_DELL_LAPTOP=m
>>
>> However, I found dell-laptop is not loaded on Latitude 7480 as its
>> chassis type is Notebook (10), instead of 8 (Portable) or 9 (Laptop).
>> That's also what I see for newer Dell laptops.
>>
>> After I added the below entry into dell-laptop, the led works fine.
>> This is not in kernel 4.10 rc8 either, and I will submit a patch for
>> it.
>>
>>         {
>>                 .matches = {
>>                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>>                         DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /*Notebook*/
>>                 },
>>         },
> 
> Great, so it all makes sense now.  Thanks once again for investigating.
> 
> For maintainers' convenience, I am planning to submit a v3 with all the
> tags supplied by everyone who reviewed this series and also some minor
> coding style tweaks suggested along the way.
> 
> Alex, in the light of your findings quoted above, would it be okay to
> also apply your Tested-by to all patches?
> 
> Jacek, Pavel, which linux-leds branch would you like me to base v3 on?

Please use for-next branch for that.

-- 
Best regards,
Jacek Anaszewski