lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Feb 2017 21:04:40 -0800 From: Christophe Ricard <christophe.ricard@...il.com> To: Peter Huewe <peter.huewe@...ineon.com>, Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> Cc: Jason Gunthorpe <jgunthorpe@...idianresearch.com>, tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org, peterhuewe@....de, Christophe Ricard <christophe-h.ricard@...com>, stable@...r.kernel.org, Alexander Steffen <Alexander.Steffen@...ineon.com> Subject: Re: [PATCH 2/5] tpm_tis_spi: Abort transfer when too many wait states are signaled Nitpick: Are you sure this patch is necessary having #3 on top of it ? On 16/02/2017 08:08, Peter Huewe wrote: > Abort the transfer with ETIMEDOUT when the TPM signals more than > TPM_RETRY wait states. Continuing with the transfer in this state > will only lead to arbitrary failures in other parts of the code. > > Cc: <stable@...r.kernel.org> > Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy") > Signed-off-by: Alexander Steffen <Alexander.Steffen@...ineon.com> > Signed-off-by: Peter Huewe <peter.huewe@...ineon.com> > --- > drivers/char/tpm/tpm_tis_spi.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c > index 6e1a3c43f621..d782b9974c14 100644 > --- a/drivers/char/tpm/tpm_tis_spi.c > +++ b/drivers/char/tpm/tpm_tis_spi.c > @@ -101,6 +101,11 @@ static int tpm_tis_spi_transfer(struct tpm_tis_data *data, u32 addr, u8 len, > goto exit; > } > > + if (i == TPM_RETRY) { > + ret = -ETIMEDOUT; > + goto exit; > + } > + > spi_xfer.cs_change = 0; > spi_xfer.len = len; >
Powered by blists - more mailing lists