lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <372283237.23068299.1487320918001.JavaMail.zimbra@redhat.com> Date: Fri, 17 Feb 2017 03:41:58 -0500 (EST) From: Paolo Bonzini <pbonzini@...hat.com> To: Bandan Das <bsd@...hat.com> Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org Subject: Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls ----- Original Message ----- > From: "Bandan Das" <bsd@...hat.com> > To: "Paolo Bonzini" <pbonzini@...hat.com> > Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org > Sent: Friday, February 17, 2017 1:04:14 AM > Subject: Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls > > Paolo Bonzini <pbonzini@...hat.com> writes: > > > Signed-off-by: Paolo Bonzini <pbonzini@...hat.com> > > --- > > I took a quick look and found these two potential > consumers of these set/clear wrappers. > > vmcs_set_secondary_exec_control() > vmx_set_virtual_x2apic_mode() > > Since this has been reviewed already, > we can just have them later in a follow up > (unless you left them out intentionally). Both of these can both set and clear bits, so they could be the consumer of a new function void vmcs_write_bits(u16 field, u32 value, u32 mask) but I don't see much benefit in introducing it; the cognitive load is higher than vmcs_{set,clear}_bits. Paolo
Powered by blists - more mailing lists