linux-kernel - Re: [PATCH] KVM: race-free exit from KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0f8d9bf-b438-a011-fe38-fa83a2733631@redhat.com>
Date:   Fri, 17 Feb 2017 10:40:29 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     David Hildenbrand <david@...hat.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     james.hogan@...tec.com, marc.zyngier@....com,
        kvm-ppc@...r.kernel.org, borntraeger@...ibm.com, paulus@...ba.org,
        cornelia.huck@...ibm.com, kvmarm@...ts.cs.columbia.edu
Subject: Re: [PATCH] KVM: race-free exit from KVM_RUN without POSIX signals



On 16/02/2017 20:26, David Hildenbrand wrote:
> As mentioned already on IRC, maybe something like "block_vcpu_run" would
> fit better now.

Hmm, the purpose of the flag is cause an immediate exit and it does do
so...  Surely incorrect (or just uncommon) usage will prevent a VCPU
from running, but that is just a side effect of the semantics, not the
intended usage.

Paolo

> But this is also ok and looks good to me.
> 
> Reviewed-by: David Hildenbrand <david@...hat.com>