linux-kernel - Re: [PATCH] Add possibility to define bits-per-word property.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Feb 2017 11:06:44 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Adrian Fiergolski <adrian.fiergolski@...n.ch>
Cc:     linux-spi@...r.kernel.org, broonie@...nel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Add possibility to define bits-per-word property.

Hi Adrian,

Please review the style to match the kernel's (and the rest of the
code in the file). See an example below and
https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst

(I have no idea regarding the functional changes on this patch, I just
noticed the email coming from CERN and therefore I replied :-)

Cheers,
Miguel

On Thu, Feb 16, 2017 at 2:39 PM, Adrian Fiergolski
<adrian.fiergolski@...n.ch> wrote:
>
> Signed-off-by: Adrian Fiergolski <adrian.fiergolski@...n.ch>
> ---
>  drivers/spi/spi.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index 0239b45..d2267e9 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -1549,6 +1549,17 @@ of_register_spi_device(struct spi_master *master, struct device_node *nc)
>         }
>         spi->max_speed_hz = value;
>
> +       /* Device bits-per-word */
> +       if( ! of_property_read_u32(nc, "spi-bits-per-word", &value) ){

e.g.

 if (!of_property_read_u32(nc, "spi-bits-per-word", &value)) {

>
> +         if( value > 32 )
> +           dev_warn(&master->dev,
> +                    "bits-per-word %d not supported\n",
> +                    value);
> +         else
> +           spi->bits_per_word = value;
> +       }
> +
> +
>         /* Store a pointer to the node in the device structure */
>         of_node_get(nc);
>         spi->dev.of_node = nc;
> @@ -1626,6 +1637,13 @@ static int acpi_spi_add_resource(struct acpi_resource *ares, void *data)
>
>                         spi->max_speed_hz = sb->connection_speed;
>
> +                       if(sb->data_bit_length > 32)
> +                                   dev_warn(&master->dev,
> +                                            "bits-per-word %d not supported\n",
> +                                            sb->data_bit_length);
> +                       else
> +                         spi->bits_per_word = sb->data_bit_length;
> +
>                         if (sb->clock_phase == ACPI_SPI_SECOND_PHASE)
>                                 spi->mode |= SPI_CPHA;
>                         if (sb->clock_polarity == ACPI_SPI_START_HIGH)
> --
> 2.9.3
>