linux-kernel - Re: [PATCH] building libtraceevent with clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Feb 2017 10:44:37 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Namhyung Kim <namhyung@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] building libtraceevent with clang

Em Thu, Feb 16, 2017 at 09:00:23PM -0500, Steven Rostedt escreveu:
> On Mon, 13 Feb 2017 14:20:20 -0300
> Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> > +++ b/tools/lib/traceevent/plugin_function.c
> > @@ -130,7 +130,7 @@ static int function_handler(struct trace_seq *s, struct pevent_record *record,
> >  	unsigned long long pfunction;
> >  	const char *func;
> >  	const char *parent;
> > -	int index;
> > +	int index = 0;
 
> I went to apply this to trace-cmd's version, and it failed to apply.  Then I
> realized that I had this fixed back in 2015, but missed sending it.

> That's because I don't strictly follow the 80 column limit for some of the if
> statements (I find the break up ugly), and when doing diffs, this got lost in
> the diffs of the 80 column limits ones done with the port to the kernel tree.
> :-/

I'm not strict about it either:

$ find tools/perf/ -name "*.[ch]" | xargs cat | wc -l
161984
$ find tools/perf/ -name "*.[ch]" | xargs expand | cut -c80- | grep -v ^$ | wc -l
3706
$ 

2.29%

You (well, libtracevent) are a bit more strict:

$ find tools/lib/traceevent/ -name "*.[ch]" | xargs cat | wc -l
13814
$ find tools/lib/traceevent/ -name "*.[ch]" | xargs expand | cut -c80- | grep -v ^$ | wc -l
184
$ 

1.33%

For reference, the whole kernel, modulo tools/

$ find . -name "*.[ch]" | grep -v ^\.\/tools | xargs cat | wc -l
20162880
$ find . -name "*.[ch]" | grep -v ^\.\/tools | xargs expand | cut -c80- | grep -v ^$ | wc -l
439722
$

2.18%

Using functions to avoid too deep if statements usually helps here tho :-)

- Arnaldo
 
> -- Steve
> 
> 
> >  
> >  	if (pevent_get_field_val(s, event, "ip", record, &function, 1))
> >  		return trace_seq_putc(s, '!');
> >