linux-kernel - Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c7a3011-3418-35a5-ca2e-88c0188baccf@lwfinger.net>
Date:   Fri, 17 Feb 2017 10:14:44 -0600
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Jiri Kosina <trivial@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Chaoming Li <chaoming_li@...lsil.com.cn>,
        netdev@...r.kernel.org
Subject: Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling
 s/wrtie_addr/write_addr/

On 02/17/2017 09:36 AM, Geert Uytterhoeven wrote:
> As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky
> register acronym, but a simple misspelling of "write".
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: Larry Finger <Larry.Finger@...inger.net>
> Cc: Chaoming Li <chaoming_li@...lsil.com.cn>
> Cc: netdev@...r.kernel.org

I'm not sure that it is possible to have a typo in a variable name. That seems 
to be within an author's prerogative. Nonetheless, the patch is OK other than it 
was sent to the wrong destination. Patches for this driver should go through 
linux-wireless@...r.kernel.org. Kalle Valo is the wireless maintainer, but it is 
not necessary to send to him directly as he usually picks up the patches from 
Patchwork.

Larry

> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> index 4f83eee1ff75bc81..546f085afb8f42fa 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> @@ -1135,13 +1135,13 @@ static u8 _rtl8821ae_dbi_read(struct rtl_priv *rtlpriv, u16 addr)
>  static void _rtl8821ae_dbi_write(struct rtl_priv *rtlpriv, u16 addr, u8 data)
>  {
>  	u8 tmp = 0, count = 0;
> -	u16 wrtie_addr, remainder = addr % 4;
> +	u16 write_addr, remainder = addr % 4;
>
> -	wrtie_addr = REG_DBI_WDATA + remainder;
> -	rtl_write_byte(rtlpriv, wrtie_addr, data);
> +	write_addr = REG_DBI_WDATA + remainder;
> +	rtl_write_byte(rtlpriv, write_addr, data);
>
> -	wrtie_addr = (addr & 0xfffc) | (BIT(0) << (remainder + 12));
> -	rtl_write_word(rtlpriv, REG_DBI_ADDR, wrtie_addr);
> +	write_addr = (addr & 0xfffc) | (BIT(0) << (remainder + 12));
> +	rtl_write_word(rtlpriv, REG_DBI_ADDR, write_addr);
>
>  	rtl_write_byte(rtlpriv, REG_DBI_FLAG, 0x1);
>
>