linux-kernel - Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42689efd-f0f8-5a61-c787-cda22bf6ef68@lwfinger.net>
Date:   Fri, 17 Feb 2017 10:42:15 -0600
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Jiri Kosina <trivial@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Chaoming Li <chaoming_li@...lsil.com.cn>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling
 s/wrtie_addr/write_addr/

On 02/17/2017 10:19 AM, Geert Uytterhoeven wrote:
> Hi Larry,
>
> On Fri, Feb 17, 2017 at 5:14 PM, Larry Finger <Larry.Finger@...inger.net> wrote:
>> On 02/17/2017 09:36 AM, Geert Uytterhoeven wrote:
>>> As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky
>>> register acronym, but a simple misspelling of "write".
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
>>> Cc: Larry Finger <Larry.Finger@...inger.net>
>>> Cc: Chaoming Li <chaoming_li@...lsil.com.cn>
>>> Cc: netdev@...r.kernel.org
>>
>> I'm not sure that it is possible to have a typo in a variable name. That
>> seems to be within an author's prerogative. Nonetheless, the patch is OK
>
> ;-)
>
>> other than it was sent to the wrong destination. Patches for this driver
>
> MAINTAINERS has your name for drivers/net/wireless/realtek/rtlwifi/.
> Perhaps that line should be dropped?

The usual hierarchy is through me to Kalle, then to DaveM, and finally to mainline.

>> should go through linux-wireless@...r.kernel.org. Kalle Valo is the wireless
>> maintainer, but it is not necessary to send to him directly as he usually
>> picks up the patches from Patchwork.
>
> I guess Jiri (trivial) will pick it up...

The only potential problem would be conflicts arising from changes merging from 
two different directions. It applies to Kalle's wireless-drivers-next branch, 
and I will try to keep it in mind as additional patches are supplied to rtl8821ae.

Larry