lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Feb 2017 09:19:56 -0800 From: Dave Hansen <dave.hansen@...el.com> To: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Andrew Morton <akpm@...ux-foundation.org>, x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Arnd Bergmann <arnd@...db.de>, "H. Peter Anvin" <hpa@...or.com> Cc: Andi Kleen <ak@...ux.intel.com>, Andy Lutomirski <luto@...capital.net>, linux-arch@...r.kernel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org, Catalin Marinas <catalin.marinas@....com>, linux-api@...r.kernel.org Subject: Re: [PATCHv3 33/33] mm, x86: introduce PR_SET_MAX_VADDR and PR_GET_MAX_VADDR On 02/17/2017 06:13 AM, Kirill A. Shutemov wrote: > +/* > + * Default maximum virtual address. This is required for > + * compatibility with applications that assumes 47-bit VA. > + * The limit can be changed with prctl(PR_SET_MAX_VADDR). > + */ > +#define MAX_VADDR_DEFAULT ((1UL << 47) - PAGE_SIZE) This is a bit goofy. It's not the largest virtual adddress that can be accessed, but the beginning of the last page. Isn't this easier to deal with in userspace if we make it a "limit", so we can do: if (addr >= limit) // error Now, we have to do: prctl(PR_GET_MAX_VADDR, &max_vaddr, 0, 0, 0); if (addr > (max_vaddr + PAGE_SIZE)) // error I don't care what you track in the kernel, but I think we need to provide a more usable number out to userspace.
Powered by blists - more mailing lists