linux-kernel - Re: Hard-coding PTY device node numbers in userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170217181538.GA9346@kroah.com>
Date:   Fri, 17 Feb 2017 10:15:38 -0800
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Florian Weimer <fw@...eb.enyo.de>
Cc:     linux-api@...r.kernel.org,
        Christian Brauner <christian.brauner@...onical.com>,
        linux-kernel@...r.kernel.org, jslaby@...e.com
Subject: Re: Hard-coding PTY device node numbers in userspace

On Fri, Feb 17, 2017 at 12:02:52PM +0100, Florian Weimer wrote:
> We want to reject PTY devices from other namespaces as valid input to
> the ttyname and ttyname_r functions, while still providing a hint to
> callers that the device is, in fact, a PTY.  Christian Brauner wrote a
> glibc patch for this:
> 
>   <https://sourceware.org/ml/libc-alpha/2017-01/msg00531.html>
> 
> It hard-codes the major PTY device number range.  Is this feasible?
> Is it part of the stable userspace ABI for the TTY subsystem?

What major numbers are you using in the patch '2' and '3'?  And yes,
major numbers are static and you should be fine to rely on them.  But
can't you test that the device is a pty to verify it?

thanks,

greg k-h