lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 17 Feb 2017 10:43:25 -0800
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nathan Howard <adanhawthorn@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Stephen Warren <swarren@...dotorg.org>,
        Lee Jones <lee@...nel.org>, Eric Anholt <eric@...olt.net>,
        Michael Zoran <mzoran@...wfest.net>,
        devel@...verdev.osuosl.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: bcm2835-audio: bcm2835.h: fix various coding
 style issues

On Fri, Feb 17, 2017 at 01:39:07PM -0500, Nathan Howard wrote:
> The following coding style issues (as per checkpatch.pl) were resolved.
> 
> WARNING: Block comments use * on subsequent lines
> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ...
> WARNING: Missing a blank line after declarations
> WARNING: Use of volatile is usually wrong:...
> WARNING: line over 80 characters
> CHECK: Concatenated strings should use spaces between elements
> CHECK: Macro argument 'vol' may be better as '(vol)' to avoid precedence issues

Please only do one thing per patch, and no, "fix style issues" is not
one thing :(

This should be a patch series, one per type of thing done.

thanks,

greg k-h

Powered by blists - more mailing lists