linux-kernel - Re: [PATCH v3] Add sysfs interface for touchpad state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 18 Feb 2017 00:20:02 +0530
From:   Ritesh Raj Sarraf <rrs@...ian.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        Ike Panhc <ike.pan@...onical.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] Add sysfs interface for touchpad state

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Fri, 2017-02-17 at 18:12 +0200, Andy Shevchenko wrote:
> > +static ssize_t touchpad_store(struct device *dev,
> > +                                struct device_attribute *attr,
> > +                                const char *buf, size_t count)
> > +{
> > +       struct ideapad_private *priv = dev_get_drvdata(dev);
> > +       int ret, state;
> > +
> > +       ret = kstrtoint(buf, 0, &state);
> > +       if (ret)
> > +               return ret;
> 
> If it's intended to be boolean, better to use kstrtobool()

Thanks. Revised patch built, tested locally, and sent (git send-email).


- -- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQCVDstmIVAB/Yn02pjpYo/LhdWkFAlinRdoACgkQpjpYo/Lh
dWljCRAAqAqvbXABNFnoObBrQ4e4nULupH/R2FuAOU+tgKJUv6Fks85TuPvoNLwb
OYMP7HoXXKf1ME4lIILEhrl6UCvlOzN4lUbxdFaUhg/NvvduHc9n5v+hFDask/BC
dA+Vt4r8KI8FH6O5O/JqxkFm0UZSVA41K15fTsX/5JunH7f+SOKPQIjMAk3/3MBm
puVtxDUTHjx0yOTpzIv0xzIrVtwAeFtfINDG/M+e5wKuurCyZ+ARvRb0melRHGXH
N4PlAAZ2BvgLqHjZqU+EqkER1wiAPkpZw0VSavT9Efw+FMy/yKoogdRLImRNR8Sh
MwAuj+U4xL572n53x09w9UBbAGAbP4O4O/1DUl2zL6MXFtHboCs+AkPP9UYaUXYG
rhi3GSPHCDk0iQuXrwMmjyDw3Ta1RFJs4aBAuRdJOiifH0nOTsA5SmX4i4Mep+9k
QuMSEIHTNQpflAuGe0/4ku+QEQDm0L7IXxzqK7Ra+P9XdqOxa5iYyrbmPxqgL0xA
+DjT/92ZvHI5IFBBk/c5ZSCaRmSchaHiHWPG3z7qcP770jKqKAeMVeyxMAo8q/h7
J0E7w5p+kFn/71+3E4TvM1pC13mHwspAqheoIfYObPS1nU3XVIUpJ9A/rLLcvXY5
920LxV0Yz+Gs1GcgVlItOSSUhPeh11atzV3Y4UAnMuvh7RWWzDc=
=6Bli
-----END PGP SIGNATURE-----