lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Feb 2017 12:52:44 -0800 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: "H. Nikolaus Schaller" <hns@...delico.com> Cc: Sebastian Reichel <sre@...nel.org>, Mark Rutland <mark.rutland@....com>, Benoît Cousson <bcousson@...libre.com>, Tony Lindgren <tony@...mide.com>, Russell King <linux@...linux.org.uk>, Arnd Bergmann <arnd@...db.de>, Michael Welling <mwelling@...e.org>, Mika Penttilä <mika.penttila@...tfour.com>, Javier Martinez Canillas <javier@....samsung.com>, Igor Grinberg <grinberg@...pulab.co.il>, "Andrew F. Davis" <afd@...com>, Mark Brown <broonie@...nel.org>, Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh+dt@...nel.org>, Alexander Stein <alexander.stein@...tec-electronic.com>, Eric Engestrom <eric@...estrom.ch>, Hans de Goede <hdegoede@...hat.com>, Benjamin Tissoires <benjamin.tissoires@...hat.com>, Petr Cvek <petr.cvek@....cz>, Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil <hans.verkuil@...co.com>, Nick Dyer <nick@...anahar.org>, Siebren Vroegindeweij <siebren.vroegindeweij@...mail.com>, Michel Verlaan <michel.verl@...il.com>, linux-input@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org, letux-kernel@...nphoenux.org, linux-iio@...r.kernel.org, kernel@...a-handheld.com Subject: Re: [PATCH v9 2/8] drivers:input:tsc2007: check for presence and power down tsc2007 during probe On Wed, Dec 28, 2016 at 03:53:17PM +0100, H. Nikolaus Schaller wrote: > 1. check if chip is really present and don't succeed if it isn't. > 2. if it succeeds, power down the chip until accessed > > Signed-off-by: H. Nikolaus Schaller <hns@...delico.com> Applied, thank you. > --- > drivers/input/touchscreen/tsc2007.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/input/touchscreen/tsc2007.c b/drivers/input/touchscreen/tsc2007.c > index c1d9593..76b462b 100644 > --- a/drivers/input/touchscreen/tsc2007.c > +++ b/drivers/input/touchscreen/tsc2007.c > @@ -529,6 +529,14 @@ static int tsc2007_probe(struct i2c_client *client, > > tsc2007_stop(ts); > > + /* power down the chip (TSC2007_SETUP does not ACK on I2C) */ > + err = tsc2007_xfer(ts, PWRDOWN); > + if (err < 0) { > + dev_err(&client->dev, > + "Failed to setup chip: %d\n", err); > + return err; /* usually, chip does not respond */ > + } > + > err = input_register_device(input_dev); > if (err) { > dev_err(&client->dev, > -- > 2.7.3 > -- Dmitry
Powered by blists - more mailing lists