linux-kernel - Re: [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3537f379-4d93-d8fe-6892-cae09ce0b43a@caviumnetworks.com>
Date:   Fri, 17 Feb 2017 13:41:21 -0800
From:   David Daney <ddaney@...iumnetworks.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        David Daney <david.daney@...ium.com>, netdev@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.

On 02/17/2017 12:09 PM, Florian Fainelli wrote:
> On 02/17/2017 12:04 PM, David Daney wrote:
>> Some Cavium dev boards have firmware which doesn't supply a proper
>> ethernet-phy-ieee802.3-c22" compatible property.  Restore these boards
>> to working order by whitelisting this compatible value.
>>
>> Signed-off-by: David Daney <david.daney@...ium.com>
>
> Acked-by: Florian Fainelli <f.fainelli@...il.com>
>
>> ---
>>  drivers/of/of_mdio.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
>> index 262281b..0b29798 100644
>> --- a/drivers/of/of_mdio.c
>> +++ b/drivers/of/of_mdio.c
>> @@ -147,6 +147,7 @@ EXPORT_SYMBOL(of_mdio_parse_addr);
>>   */
>>  static const struct of_device_id whitelist_phys[] = {
>>  	{ .compatible = "brcm,40nm-ephy" },
>> +	{ .compatible = "broadcom,bcm5241" },
>
> And that's not the vendor prefix from vendor-prefixes.txt.

No, that dts containing this value predates vendor-prefixes.txt.

Previous to
commit 801a8ef54e8b ("of: phy: Only register a phy device for phys"), 
the form of the compatible string didn't matter for phys
>
>
>>  	{ .compatible = "marvell,88E1111", },
>>  	{ .compatible = "marvell,88e1116", },
>>  	{ .compatible = "marvell,88e1118", },
>>
>
>