lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Feb 2017 15:04:16 -0800 From: Joe Perches <joe@...ches.com> To: Nathan Howard <adanhawthorn@...il.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Florian Fainelli <f.fainelli@...il.com>, Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, bcm-kernel-feedback-list@...adcom.com, Stephen Warren <swarren@...dotorg.org>, Lee Jones <lee@...nel.org>, Eric Anholt <eric@...olt.net>, Michael Zoran <mzoran@...wfest.net>, devel@...verdev.osuosl.org, linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote: > Fix checkpatch.pl warning of the form "WARNING: Use of volatile is > usually wrong: see Documentation/process/volatile-considered-harmful.rst." Why are you sure the volatile use is not necessary? > Signed-off-by: Nathan Howard <adanhawthorn@...il.com> > --- > drivers/staging/bcm2835-audio/bcm2835.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging/bcm2835-audio/bcm2835.h > index 2f9d1c9..08f7ad6 100644 > --- a/drivers/staging/bcm2835-audio/bcm2835.h > +++ b/drivers/staging/bcm2835-audio/bcm2835.h > @@ -125,8 +125,8 @@ struct bcm2835_alsa_stream { > struct semaphore buffers_update_sem; > struct semaphore control_sem; > spinlock_t lock; > - volatile unsigned int control; > - volatile unsigned int status; > + unsigned int control; > + unsigned int status; > > int open; > int running;
Powered by blists - more mailing lists