linux-kernel - Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1702182012240.2383@hadrien>
Date:   Sat, 18 Feb 2017 20:12:57 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     simran singhal <singhalsimran0@...il.com>
cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed
 unnecessary parentheses



On Sun, 19 Feb 2017, simran singhal wrote:

> Extra parentheses were causing checkpatch issues
> and were removed.
>
> Signed-off-by: simran singhal <singhalsimran0@...il.com>
> ---
>  drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index cded0f4..1391c91 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -297,7 +297,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
>  		u8	EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
>
>  		memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));
> -		pCapELE = (struct ht_capab_ele *)&(posHTCap[4]);
> +		pCapELE = (struct ht_capab_ele *)&posHTCap[4];
>  		*len = 30 + 2;
>  	} else {
>  		pCapELE = (struct ht_capab_ele *)posHTCap;
> @@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
>  	pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
>  	pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
>
> -	memset((void *)(&(pHTInfo->SelfHTCap)), 0,
> +	memset((void *)(&pHTInfo->SelfHTCap), 0,

You don't need the parens around the argument of the cast either.

julia

>  		sizeof(pHTInfo->SelfHTCap));
> -	memset((void *)(&(pHTInfo->SelfHTInfo)), 0,
> +	memset((void *)(&pHTInfo->SelfHTInfo), 0,
>  		sizeof(pHTInfo->SelfHTInfo));
> -	memset((void *)(&(pHTInfo->PeerHTCapBuf)), 0,
> +	memset((void *)(&pHTInfo->PeerHTCapBuf), 0,
>  		sizeof(pHTInfo->PeerHTCapBuf));
> -	memset((void *)(&(pHTInfo->PeerHTInfoBuf)), 0,
> +	memset((void *)(&pHTInfo->PeerHTInfoBuf), 0,
>  		sizeof(pHTInfo->PeerHTInfoBuf));
>
>  	pHTInfo->bSwBwInProgress = false;
> @@ -685,7 +685,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
>  	pHTInfo->IOTRaFunc = 0;
>
>  	{
> -		u8 *RegHTSuppRateSets = &(ieee->RegHTSuppRateSet[0]);
> +		u8 *RegHTSuppRateSets = &ieee->RegHTSuppRateSet[0];
>
>  		RegHTSuppRateSets[0] = 0xFF;
>  		RegHTSuppRateSets[1] = 0xFF;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218183648.GA2680%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>