linux-kernel - Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1702182046330.2383@hadrien>
Date:   Sat, 18 Feb 2017 20:46:50 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Joe Perches <joe@...ches.com>
cc:     simran singhal <singhalsimran0@...il.com>,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed
 unnecessary parentheses



On Sat, 18 Feb 2017, Joe Perches wrote:

> On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote:
> > On Sun, 19 Feb 2017, simran singhal wrote:
> > > Extra parentheses were causing checkpatch issues
> > > and were removed.
> []
> > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> []
> > > @@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
> > >  	pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
> > >  	pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
> > >
> > > -	memset((void *)(&(pHTInfo->SelfHTCap)), 0,
> > > +	memset((void *)(&pHTInfo->SelfHTCap), 0,
> >
> > You don't need the parens around the argument of the cast either.
>
> Nor need the cast at all.
>
> 	memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap));
>
> etc...

Indeed.  Thanks!

julia