linux-kernel - Re: [Outreachy kernel] [PATCH 1/6] staging: vt6655: Compress return logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1702182138420.2383@hadrien>
Date:   Sat, 18 Feb 2017 21:42:36 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     simran singhal <singhalsimran0@...il.com>
cc:     forest@...ttletooquiet.net, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH 1/6] staging: vt6655: Compress return
 logic



On Sun, 19 Feb 2017, simran singhal wrote:

> Simplify function returns by merging assignment and return into
> one command line.
> Found with Coccinelle
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
>      e;
> -return ret;
>
> Signed-off-by: simran singhal <singhalsimran0@...il.com>
> ---
>  drivers/staging/vt6655/card.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index e0c9281..b513846 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -920,7 +920,7 @@ u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF1, u64 qwTSF2)
>
>  	qwTSFOffset = qwTSF1 - qwTSF2;
>
> -	return qwTSFOffset;
> +	return qwTSF1 - qwTSF2;

It looks like you can completely get rid of the variable qwTSFOffset as
well.

Actually, it seems that you didn't use the patch that Coccinelle gave you,
because that should have removed the assignment also.  By default
Coccinelle prints a patch on standard output.  You can redirect that into
a file, and if you like it, you can apply it to your code, using
patch -p1 < {file}.  Another option is the --in-place argument to spatch.
Then you would want to do git diff afterwards to see what Coccinelle did.

julia


>  }
>
>  /*
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218202056.GA3995%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>