linux-kernel - Re: [Outreachy kernel] [PATCH v2 1/6] staging: vt6655: Compress return logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1702182211000.2383@hadrien>
Date:   Sat, 18 Feb 2017 22:11:46 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     simran singhal <singhalsimran0@...il.com>
cc:     forest@...ttletooquiet.net, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 1/6] staging: vt6655: Compress
 return logic



On Sun, 19 Feb 2017, simran singhal wrote:

> gregkh@...uxfoundation.org,devel@...verdev.osuosl.org,linux-kernel@...r.kernel.org,outreachy-kernel@...glegroups.com
> Bcc:
> Subject: [PATCH v2 1/6] staging: vt6655: Compress return logic
> Reply-To:

This didn't come out well.

>
> Simplify function returns by merging assignment and return into
> one command line.
> Found with Coccinelle
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
>      e;
> -return ret;
>
> Signed-off-by: simran singhal <singhalsimran0@...il.com>
> ---
>
>  v2:
>    -Removed assignment
>
>  drivers/staging/vt6655/card.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index e0c9281..9a8999f 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -918,9 +918,7 @@ u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF1, u64 qwTSF2)
>
>  	qwTSF2 += (u64)wRxBcnTSFOffst;
>
> -	qwTSFOffset = qwTSF1 - qwTSF2;
> -
> -	return qwTSFOffset;
> +	return qwTSF1 - qwTSF2;

It's not just the assignment that can go.  All mentions of the variable
are useless, ie the declaration too.

julia

>  }
>
>  /*
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218210740.GA14258%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>