linux-kernel - Re: [Suggestion/Problems] perf annoate: Some problems related to the source code view and Improvement of it with line numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <28f6e48a-9c4e-82e8-d48a-6b5f7aaae768@gmail.com>
Date:   Sat, 18 Feb 2017 09:15:49 +0900
From:   Taeung Song <treeze.taeung@...il.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...nel.org>,
        perf group <linux-perf-users@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [Suggestion/Problems] perf annoate: Some problems related to the
 source code view and Improvement of it with line numbers



On 02/17/2017 10:29 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Feb 17, 2017 at 11:33:29AM +0900, Taeung Song escreveu:
>> Hi, Arnaldo :)
>>
>> Regarding perf annotate:
>>
>> 1) Problem : wrong line numbers on perf-annotate (both stdio and TUI)
>> 2) Problem : wrong sum of overhead(percent) matching source lines
>> 3) Suggestion : new option showing only source code per function
>>                 with overhead info (to be more readable :) )
>>
>> I'll send the patchset for them, maybe it'll a bit take time.
>> But I won't be long..
>
> Concentrate on the first, send the patch, while waiting for review, work
> on the second, and so on :-)
>
> - Arnaldo
>

Understood!
I appreciate your concern :)

Thanks,
Taeung