lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 18 Feb 2017 14:16:03 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     simran singhal <singhalsimran0@...il.com>
cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH 1/6] staging: rtl8192e: Replaced
 comparison to NULL statements



On Sat, 18 Feb 2017, simran singhal wrote:

> This patch corrects check generated by checkpatch.pl by

There is not much information in the first line.  Use the imperative:

Replace comparisons to NULL by ...

> replacing comparison to null statements with equivalent
> statements in the form of "!x".

Actually, they are expressions.  An expression returns a value.  A
statement is performed for its side effects only.

julia

> Signed-off-by: simran singhal <singhalsimran0@...il.com>
> ---
>  drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 20260af..bdbd21c 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -83,12 +83,12 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,
>  	netdev_dbg(ieee->dev, "%s(): frame(%d) sentd to: %pM, ieee->dev:%p\n",
>  		   __func__, type, Dst, ieee->dev);
>
> -	if (pBA == NULL) {
> +	if (!pBA) {
>  		netdev_warn(ieee->dev, "pBA is NULL\n");
>  		return NULL;
>  	}
>  	skb = dev_alloc_skb(len + sizeof(struct rtllib_hdr_3addr));
> -	if (skb == NULL)
> +	if (!skb)
>  		return NULL;
>
>  	memset(skb->data, 0, sizeof(struct rtllib_hdr_3addr));
> @@ -154,7 +154,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device *ieee, u8 *dst,
>  	DelbaParamSet.field.TID	= pBA->BaParamSet.field.TID;
>
>  	skb = dev_alloc_skb(len + sizeof(struct rtllib_hdr_3addr));
> -	if (skb == NULL)
> +	if (!skb)
>  		return NULL;
>
>  	skb_reserve(skb, ieee->tx_headroom);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218071115.GA10540%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>

Powered by blists - more mailing lists