linux-kernel - Re: [PATCH] thermal: mt8173: minor mtk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46d6c448-a669-a748-acfa-8ed129c65b51@gmail.com>
Date:   Mon, 20 Feb 2017 12:30:44 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Eduardo Valentin <edubezval@...il.com>,
        Dawei Chien <dawei.chien@...iatek.com>
Cc:     Zhang Rui <rui.zhang@...el.com>, Rob Herring <robh+dt@...nel.org>,
        Pawel Moll <pawel.moll@....com>,
        Mark Rutland <mark.rutland@....com>,
        Ian Campbell <ijc+devicetree@...lion.org.uk>,
        Kumar Gala <galak@...eaurora.org>,
        Russell King <linux@...linux.org.uk>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, srv_heupstream@...iatek.com,
        Sascha Hauer <kernel@...gutronix.de>,
        Fan Chen <fan.chen@...iatek.com>,
        Eddie Huang <eddie.huang@...iatek.com>,
        Yingjoe Chen <yingjoe.chen@...iatek.com>,
        Erin Lo <erin.lo@...iatek.com>
Subject: Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups



On 19/02/17 02:23, Eduardo Valentin wrote:
> On Mon, Feb 13, 2017 at 05:01:58PM +0800, Dawei Chien wrote:
>> Hi, Matthias,
>>
>> On Thu, 2017-02-09 at 22:25 +0100, Matthias Brugger wrote:
>>>
>>> On 02/08/2017 06:31 AM, Dawei Chien wrote:
>>>> Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors.
>>>> However, Currently thermal driver don't need read TEMP_MSR3 since
>>>> thermal controller only use 3 sensors for each thermal bank.
>>>>
>>>> Signed-off-by: Dawei Chien <dawei.chien@...iatek.com>
>>>> ---
>>>
>>> Actually the commit message should state:
>>> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
>>>
>>> ...and get backported to v4.9 and v4.10.
>>>
>>> Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
>>>
>>> Regards,
>>> Matthias
>>
>> Thank you for your review. I would add below commit message on next
>> version. However, currently 8173 thermal driver would not read TEMP_MSR3
>> since thermal driver only use 3 sensors on each bank, this patch would
>> not effect temperature.
>> Only if thermal driver use 4 sensors on any thermal bank, would read
>> third sensor two times, and lose fourth sensor of vale.
>> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
>>
>
> Please send a new version with the tag in the commit message.
>

And don't forget to add stable@...r.kernel.org so that the fix ends up 
in the older kernels as well.

Regards,
Matthias