linux-kernel - Re: [PATCH] fbdev: ssd1307fb: include linux/gpio/consumer.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Feb 2017 13:52:54 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Tomi Valkeinen <tomi.valkeinen@...com>, Jyri Sarha <jsarha@...com>,
        LABBE Corentin <clabbe.montjoie@...il.com>,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbdev: ssd1307fb: include linux/gpio/consumer.h


Hi,

On Friday, February 17, 2017 03:41:42 PM Arnd Bergmann wrote:
> Changing this driver to the gpiod API requires the use of the
> new-style header, depending on the configuration:
> 
> drivers/video/fbdev/ssd1307fb.c: In function 'ssd1307fb_probe':
> drivers/video/fbdev/ssd1307fb.c:569:15: error: implicit declaration of function 'devm_gpiod_get_optional';did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration]
> drivers/video/fbdev/ssd1307fb.c:570:11: error: 'GPIOD_OUT_LOW' undeclared (first use in this function)
> 
> Fixes: 72db33355c14 ("fbdev: ssd1307fb: Start to use gpiod API for reset gpio")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks for fixing this.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics