linux-kernel - Re: [PATCH 5/5] mm: convert mm_struct.mm_count from atomic_t to refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Feb 2017 21:16:03 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Elena Reshetova <elena.reshetova@...el.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, peterz@...radead.org,
        gregkh@...uxfoundation.org, viro@...iv.linux.org.uk,
        catalin.marinas@....com, mingo@...hat.com,
        akpm@...ux-foundation.org, arnd@...db.de, luto@...nel.org,
        Elena Reshetova <elena.reshetova@...el.com>,
        Hans Liljestrand <ishkamiel@...il.com>,
        Kees Cook <keescook@...omium.org>,
        David Windsor <dwindsor@...il.com>
Subject: Re: [PATCH 5/5] mm: convert mm_struct.mm_count from atomic_t to
 refcount_t

Hi Elena,

[auto build test ERROR on mmotm/master]
[also build test ERROR on next-20170220]
[cannot apply to linus/master linux/master v4.10]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Elena-Reshetova/mm-subsystem-refcounter-conversions/20170220-190351
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: blackfin-BF561-EZKIT-SMP_defconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

All errors (new ones prefixed by >>):

   arch/blackfin/mach-common/smp.c: In function 'cpu_die':
>> arch/blackfin/mach-common/smp.c:426:13: error: passing argument 1 of 'atomic_dec' from incompatible pointer type [-Werror=incompatible-pointer-types]
     atomic_dec(&init_mm.mm_count);
                ^
   In file included from arch/blackfin/include/asm/atomic.h:45:0,
                    from include/linux/atomic.h:4,
                    from arch/blackfin/include/asm/spinlock.h:14,
                    from include/linux/spinlock.h:87,
                    from include/linux/seqlock.h:35,
                    from include/linux/time.h:5,
                    from include/linux/stat.h:18,
                    from include/linux/module.h:10,
                    from arch/blackfin/mach-common/smp.c:10:
   include/asm-generic/atomic.h:211:20: note: expected 'atomic_t * {aka struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
    static inline void atomic_dec(atomic_t *v)
                       ^~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/atomic_dec +426 arch/blackfin/mach-common/smp.c

0b39db28 Graf Yang        2009-12-28  410  		return -EPERM;
0b39db28 Graf Yang        2009-12-28  411  
0b39db28 Graf Yang        2009-12-28  412  	set_cpu_online(cpu, false);
0b39db28 Graf Yang        2009-12-28  413  	return 0;
0b39db28 Graf Yang        2009-12-28  414  }
0b39db28 Graf Yang        2009-12-28  415  
13dff62d Paul Gortmaker   2013-06-18  416  int __cpu_die(unsigned int cpu)
0b39db28 Graf Yang        2009-12-28  417  {
a17b4b74 Paul E. McKenney 2015-02-26  418  	return cpu_wait_death(cpu, 5);
0b39db28 Graf Yang        2009-12-28  419  }
0b39db28 Graf Yang        2009-12-28  420  
0b39db28 Graf Yang        2009-12-28  421  void cpu_die(void)
0b39db28 Graf Yang        2009-12-28  422  {
a17b4b74 Paul E. McKenney 2015-02-26  423  	(void)cpu_report_death();
0b39db28 Graf Yang        2009-12-28  424  
afdf6066 Elena Reshetova  2017-02-20  425  	refcount_dec(&init_mm.mm_users);
0b39db28 Graf Yang        2009-12-28 @426  	atomic_dec(&init_mm.mm_count);
0b39db28 Graf Yang        2009-12-28  427  
0b39db28 Graf Yang        2009-12-28  428  	local_irq_disable();
0b39db28 Graf Yang        2009-12-28  429  	platform_cpu_die();
0b39db28 Graf Yang        2009-12-28  430  }
0b39db28 Graf Yang        2009-12-28  431  #endif

:::::: The code at line 426 was first introduced by commit
:::::: 0b39db28b953945232719e7ff6fb802aa8a2be5f Blackfin: SMP: add PM/CPU hotplug support

:::::: TO: Graf Yang <graf.yang@...log.com>
:::::: CC: Mike Frysinger <vapier@...too.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (10736 bytes)