linux-kernel - Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00ec01d28b29$adb7ce70$09276b50$@alibaba-inc.com>
Date:   Mon, 20 Feb 2017 11:30:26 +0800
From:   "Hillf Danton" <hillf.zj@...baba-inc.com>
To:     "'Aneesh Kumar K.V'" <aneesh.kumar@...ux.vnet.ibm.com>,
        <akpm@...ux-foundation.org>, "'Rik van Riel'" <riel@...riel.com>,
        "'Mel Gorman'" <mgorman@...hsingularity.net>
Cc:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault.


On February 19, 2017 6:00 PM Aneesh Kumar K.V wrote: 
> 
> We are using wrong flag value in task_numa_falt function. This can result in
> us doing wrong numa fault statistics update, because we update num_pages_migrate
> and numa_fault_locality etc based on the flag argument passed.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>

Fix: bae473a423 ("mm: introduce fault_env")
Acked-by: Hillf Danton <hillf.zj@...baba-inc.com>

> ---
>  mm/huge_memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 5f3ad65c85de..8f1d93257fb9 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -1333,7 +1333,7 @@ int do_huge_pmd_numa_page(struct vm_fault *vmf, pmd_t pmd)
> 
>  	if (page_nid != -1)
>  		task_numa_fault(last_cpupid, page_nid, HPAGE_PMD_NR,
> -				vmf->flags);
> +				flags);
> 
>  	return 0;
>  }
> --
> 2.7.4