linux-kernel - Re: [PATCH 1/1] rtc: cpcap: new rtc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170220163858.4ocqnfhei67wbtl3@piout.net>
Date:   Mon, 20 Feb 2017 17:38:58 +0100
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] rtc: cpcap: new rtc driver

On 20/02/2017 at 08:31:56 -0800, Tony Lindgren wrote:
> * Sebastian Reichel <sre@...nel.org> [170219 23:37]:
> > This driver supports the Motorola CPCAP PMIC found on
> > some of Motorola's mobile phones, such as the Droid 4.
> 
> Hey that's cool, works for me for reading and setting date :)
> Just noticed one thing, see below.
> 
> > +Requires node properties:
> > +- compatible: should contain "motorola,cpcap-rtc"
> > +- interrupts: An interrupt specifier for alarm and 1 Hz irq
> > +
> > +Example:
> > +
> > +cpcap_rtc: rtc {
> > +	compatible = "motorola,cpcap-rtc";
> > +	interrupts = <39 IRQ_TYPE_NONE>, <26 IRQ_TYPE_NONE>;
> > +};
> 
> I tried rtcwake -s 3, but got the following:
> 
> rtcwake: cannot open /sys/class/rtc/rtc0/device/power/wakeup:
> No such file or directory
> rtcwake: /dev/rtc0 not enabled for wakeup events
> 
> Then tried adding "wakeup-source" to above but I think the driver
> needs something, maybe probably just PM ops?
> 

Probably device_init_wakeup(dev, 1) ?


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com