linux-kernel - Re: [PATCH v2 1/3] module: verify address is read-only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170220091417.14b21484@xeon-e3>
Date:   Mon, 20 Feb 2017 09:14:17 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     "Eddie Kovsky" <ewk@...ovsky.org>
Cc:     <jeyu@...hat.com>, <rusty@...tcorp.com.au>,
        <keescook@...omium.org>, "KY Srinivasan" <kys@...rosoft.com>,
        "Haiyang Zhang" <haiyangz@...rosoft.com>,
        "Stephen Hemminger" <sthemmin@...rosoft.com>,
        <linux-kernel@...r.kernel.org>,
        <kernel-hardening@...ts.openwall.com>
Subject: Re: [PATCH v2 1/3] module: verify address is read-only

On Fri, 17 Feb 2017 21:58:42 -0800
"Eddie Kovsky" <ewk@...ovsky.org> wrote:

> Implement a mechanism to check if a module's address is in
> the rodata or ro_after_init sections. It mimics the exsiting functions
> that test if an address is inside a module's text section.
> 
> Signed-off-by: Eddie Kovsky <ewk@...ovsky.org>

I don't see the point of this for many of the hyper-v functions.
They are only called from a small number of places, and this can be validated
by code inspection. Adding this seems just seems to be code bloat to me.