linux-kernel - Re: [PATCH 2/4] perf: Keep AUX flags in the output handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d1ecixye.fsf@ashishki-desk.ger.corp.intel.com>
Date:   Mon, 20 Feb 2017 19:17:13 +0200
From:   Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        vince@...ter.net, eranian@...gle.com,
        Arnaldo Carvalho de Melo <acme@...radead.org>,
        Will Deacon <will.deacon@....com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>
Subject: Re: [PATCH 2/4] perf: Keep AUX flags in the output handle

kbuild test robot <lkp@...el.com> writes:

> All errors (new ones prefixed by >>):
>
>    In file included from ./arch/arm64/include/generated/asm/local.h:1:0,
>                     from drivers/hwtracing/coresight/coresight-etb10.c:15:
>    drivers/hwtracing/coresight/coresight-etb10.c: In function 'etb_update_buffer':
>>> drivers/hwtracing/coresight/coresight-etb10.c:431:17: error: 'struct cs_buffers' has no member named 'lost'
>       local_inc(&buf->lost);
>                     ^
>    include/asm-generic/local.h:30:40: note: in definition of macro 'local_inc'

Ah shoot. Peter, can you fold this in:

>From 8272adc208eb2ad874e3952766282624d035ea50 Mon Sep 17 00:00:00 2001
From: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Date: Mon, 20 Feb 2017 19:15:27 +0200
Subject: [PATCH] fixup! perf: Keep AUX flags in the output handle

---
 drivers/hwtracing/coresight/coresight-etb10.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c
index 82c8ddcf09..979ea6ec79 100644
--- a/drivers/hwtracing/coresight/coresight-etb10.c
+++ b/drivers/hwtracing/coresight/coresight-etb10.c
@@ -428,7 +428,7 @@ static void etb_update_buffer(struct coresight_device *csdev,
 		if (read_ptr > (drvdata->buffer_depth - 1))
 			read_ptr -= drvdata->buffer_depth;
 		/* let the decoder know we've skipped ahead */
-		local_inc(&buf->lost);
+		perf_aux_output_flag(handle, PERF_AUX_FLAG_TRUNCATED);
 	}
 
 	/* finally tell HW where we want to start reading from */
-- 
2.11.0