linux-kernel - Re: [next-20170217] WARN @/arch/powerpc/include/asm/xics.h:124 .icp_hv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1487624024.23576.181.camel@au1.ibm.com>
Date:   Tue, 21 Feb 2017 07:53:44 +1100
From:   Benjamin Herrenschmidt <benh@....ibm.com>
To:     Michael Ellerman <mpe@...erman.id.au>,
        Sachin Sant <sachinp@...ux.vnet.ibm.com>, tglx@...utronix.de
Cc:     linuxppc-dev@...abs.org, linux-next@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [next-20170217] WARN @/arch/powerpc/include/asm/xics.h:124
 .icp_hv_eoi+0x40/0x140

On Mon, 2017-02-20 at 21:55 +1100, Michael Ellerman wrote:
> But when we're called for CONFIG_DEBUG_SHIRQ get_irq() is not called,
> precisely because we're faking an interrupt.
> 
> I'm not sure if there's a good way to fix it :/

In the irq_replay path we have code to adjust the CPPR stack. We could
do something similar.

HOWEVER. Looking at current upstream code I don't understand the error,
the DEBUG_SHIRQ code is calling the driver's handler not the flow
handler so it shouldn't be called handle_fasteoi_irq or am I missing
something ?

Cheers,
Ben.