linux-kernel - Re: [PATCH] Input: zet6223 - Export OF device ID as module aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170220232847.GA36910@dtor-ws>
Date:   Mon, 20 Feb 2017 15:28:47 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org, Jelle van der Waa <jelle@...aa.nl>,
        Rob Herring <robh@...nel.org>, linux-input@...r.kernel.org
Subject: Re: [PATCH] Input: zet6223 - Export OF device ID as module aliases

On Mon, Feb 20, 2017 at 05:08:55PM -0300, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
> 
> Before this patch:
> 
> $ modinfo drivers/input/touchscreen/zet6223.ko | grep alias
> alias:          i2c:zet6223
> 
> After this patch:
> 
> $ modinfo drivers/input/touchscreen/zet6223.ko | grep alias
> alias:          of:N*T*Czeitec,zet6223C*
> alias:          of:N*T*Czeitec,zet6223
> alias:          i2c:zet6223
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

Applied, thank you.

> ---
> 
>  drivers/input/touchscreen/zet6223.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/zet6223.c b/drivers/input/touchscreen/zet6223.c
> index e7fb00b511ec..19ffcc7b886c 100644
> --- a/drivers/input/touchscreen/zet6223.c
> +++ b/drivers/input/touchscreen/zet6223.c
> @@ -245,6 +245,7 @@ static const struct of_device_id zet6223_of_match[] = {
>  	{ .compatible = "zeitec,zet6223" },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, zet6223_of_match);
>  
>  static const struct i2c_device_id zet6223_id[] = {
>  	{ "zet6223", 0},
> -- 
> 2.9.3
> 

-- 
Dmitry