linux-kernel - Re: [PATCH] staging/ks7010: formatting updates.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXt4sLgK368Xy9h7ONWUsmeXc3f3gtO=ecQxLwcwhbVkQ@mail.gmail.com>
Date:   Tue, 21 Feb 2017 08:59:18 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Matthew Giassa <matthew@...ssa.net>
Cc:     Wolfram Sang <wsa@...-dreams.de>,
        Greg KH <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        driverdevel <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] staging/ks7010: formatting updates.

Hi Matthew,

On Tue, Feb 21, 2017 at 5:20 AM, Matthew Giassa <matthew@...ssa.net> wrote:
> Please pardon the earlier e-mail which was missing the changelog text.

This line should be between the "---" and the diffstat below.

> Some additional style changes to appease checkpatch.

Which additional style changes?

> ---
>  drivers/staging/ks7010/ks_wlan_ioctl.h | 80 +++++++++++++++++-----------------
>  1 file changed, 41 insertions(+), 39 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
> index 84554b6..00eec18 100644
> --- a/drivers/staging/ks7010/ks_wlan_ioctl.h
> +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h

>  #include "ks_wlan.h"
>  #include <linux/netdevice.h>
>
> -int ks_wlan_read_config_file(struct ks_wlan_private *priv);
> -int ks_wlan_setup_parameter(struct ks_wlan_private *priv,
> -                            unsigned int commit_flag);
> +int ks_wlan_read_config_file(
> +               struct ks_wlan_private *priv);
> +int ks_wlan_setup_parameter(
> +               struct ks_wlan_private *priv,
> +               unsigned int commit_flag);

Really?
If checkpatch complained about the above, you should file a bug report
against checkpatch.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds