linux-kernel - Re: [PATCH] sched/core: include asm/paravirt.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a21JXApn=zGF-bWJYiZ+1RUZZZ83qM_PFz7BtHtQnH0pA@mail.gmail.com>
Date:   Tue, 21 Feb 2017 10:29:19 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched/core: include asm/paravirt.h

On Fri, Feb 17, 2017 at 3:43 PM, Arnd Bergmann <arnd@...db.de> wrote:
> One of the headers that got removed was needed after all, depending
> on the configuration:
>
> kernel/sched/core.c: In function 'update_rq_clock_task':
> kernel/sched/core.c:198:50: error: 'paravirt_steal_rq_enabled' undeclared (first use in this function); did you mean 'arch_local_irq_enable'?
>
> This restores the include.
>
> Fixes: 004172bdad64 ("sched/core: Remove unnecessary #include headers")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

The broken patch has now made it into mainline, according to the output of the
build bots.

    Arnd

>  kernel/sched/core.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index e2687118a878..c98f2fd8c0d3 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -23,6 +23,9 @@
>
>  #include <asm/switch_to.h>
>  #include <asm/tlb.h>
> +#ifdef CONFIG_PARAVIRT
> +#include <asm/paravirt.h>
> +#endif
>
>  #include "sched.h"
>  #include "../workqueue_internal.h"
> --
> 2.9.0
>