linux-kernel - Re: [PATCH] KVM: VMX: use correct vmcs_read/write for guest segment selector/base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Feb 2017 12:46:01 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Chao Peng <chao.p.peng@...ux.intel.com>, kvm@...r.kernel.org
Cc:     Radim Krčmář <rkrcmar@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] KVM: VMX: use correct vmcs_read/write for guest segment
 selector/base



On 21/02/2017 09:50, Chao Peng wrote:
> Guest segment selector is 16 bit field and guest segment base is natural
> width field. Fix two incorrect invocations accordingly.
> 
> Without this patch, build fails when aggressive inlining is used with ICC.
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Chao Peng <chao.p.peng@...ux.intel.com>

Applied, thanks.

Paolo

> ---
>  arch/x86/kvm/vmx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index a236dec..2c22aef 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -3962,7 +3962,7 @@ static void fix_rmode_seg(int seg, struct kvm_segment *save)
>  	}
>  
>  	vmcs_write16(sf->selector, var.selector);
> -	vmcs_write32(sf->base, var.base);
> +	vmcs_writel(sf->base, var.base);
>  	vmcs_write32(sf->limit, var.limit);
>  	vmcs_write32(sf->ar_bytes, vmx_segment_access_rights(&var));
>  }
> @@ -8350,7 +8350,7 @@ static void kvm_flush_pml_buffers(struct kvm *kvm)
>  static void vmx_dump_sel(char *name, uint32_t sel)
>  {
>  	pr_err("%s sel=0x%04x, attr=0x%05x, limit=0x%08x, base=0x%016lx\n",
> -	       name, vmcs_read32(sel),
> +	       name, vmcs_read16(sel),
>  	       vmcs_read32(sel + GUEST_ES_AR_BYTES - GUEST_ES_SELECTOR),
>  	       vmcs_read32(sel + GUEST_ES_LIMIT - GUEST_ES_SELECTOR),
>  	       vmcs_readl(sel + GUEST_ES_BASE - GUEST_ES_SELECTOR));
>