linux-kernel - Re: [greybus-dev] [Outreachy kernel] [PATCH v2 3/6] staging: greybus: Remove unnecessary braces

Open Source and information security mailing list archives

Date:   Tue, 21 Feb 2017 07:46:11 -0600
From:   Alex Elder <elder@...aro.org>
To:     Johan Hovold <johan@...nel.org>,
        Julia Lawall <julia.lawall@...6.fr>
Cc:     devel@...verdev.osuosl.org, elder@...nel.org,
        outreachy-kernel@...glegroups.com, linux-kernel@...r.kernel.org,
        greybus-dev@...ts.linaro.org,
        simran singhal <singhalsimran0@...il.com>
Subject: Re: [greybus-dev] [Outreachy kernel] [PATCH v2 3/6] staging: greybus:
 Remove unnecessary braces

On 02/21/2017 07:44 AM, Johan Hovold wrote:
> On Tue, Feb 21, 2017 at 02:20:50PM +0100, Julia Lawall wrote:
>>
>>
>> On Tue, 21 Feb 2017, simran singhal wrote:
>>
>>> This patch removes braces for single statement blocks. The warning
>>> was detected using checkpatch.pl.
>>> Coccinelle was used to make the change.
>>>
>>> @@
>>> expression e,e1;
>>> @@
>>> - if (e) {
>>> + if (e)
>>>   e1;
>>> - }
>>>
>>> Signed-off-by: simran singhal <singhalsimran0@...il.com>
>>
>> Acked-by: Julia Lawall <julia.lawall@...6.fr>
> 
> I do not think this patch should be merged.
> 
> Note that all of the braces you are removing are for single statements
> that span multiple lines, and that is precisely why the braces were
> added in the first place. Having braces for such statements often
> increase readability even if they are not mandated by the coding
> standard.
> 
> So I suggest this patch is dropped.

I concur.  I think the change was well-intended but I find the
practice Johan describes to improve readability of the code.

					-Alex

> 
> Thanks,
> Johan
> _______________________________________________
> greybus-dev mailing list
> greybus-dev@...ts.linaro.org
> https://lists.linaro.org/mailman/listinfo/greybus-dev
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives