linux-kernel - Re: [PATCH] dma-buf: add support for compat ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <917aff70-64f7-7224-a015-0e77951bbc1d@vodafone.de>
Date:   Tue, 21 Feb 2017 14:59:18 +0100
From:   Christian König <deathsimple@...afone.de>
To:     Marek Szyprowski <m.szyprowski@...sung.com>,
        linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc:     linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH] dma-buf: add support for compat ioctl

Am 21.02.2017 um 14:21 schrieb Marek Szyprowski:
> Add compat ioctl support to dma-buf. This lets one to use DMA_BUF_IOCTL_SYNC
> ioctl from 32bit application on 64bit kernel. Data structures for both 32
> and 64bit modes are same, so there is no need for additional translation
> layer.

Well I might be wrong, but IIRC compat_ioctl was just optional and if 
not specified unlocked_ioctl was called instead.

If that is true your patch wouldn't have any effect at all.

Regards,
Christian.

>
> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> ---
>   drivers/dma-buf/dma-buf.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> index 718f832a5c71..0007b792827b 100644
> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -325,6 +325,9 @@ static long dma_buf_ioctl(struct file *file,
>   	.llseek		= dma_buf_llseek,
>   	.poll		= dma_buf_poll,
>   	.unlocked_ioctl	= dma_buf_ioctl,
> +#ifdef CONFIG_COMPAT
> +	.compat_ioctl	= dma_buf_ioctl,
> +#endif
>   };
>   
>   /*