linux-kernel - Re: [PATCH Speakup v2] return same error value from spk_set_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201702212326.DzZC7iQC%fengguang.wu@intel.com>
Date:   Tue, 21 Feb 2017 23:21:01 +0800
From:   kbuild test robot <lkp@...el.com>
To:     "Pranay Kr. Srivastava" <pranjas@...il.com>
Cc:     kbuild-all@...org, w.d.hubbs@...il.com, chris@...-brannons.com,
        kirk@...sers.ca, samuel.thibault@...-lyon.org,
        gregkh@...uxfoundation.org, sfr@...b.auug.org.au,
        speakup@...ux-speakup.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH Speakup v2] return same error value from spk_set_key_info

Hi Pranay,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.10 next-20170220]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Pranay-Kr-Srivastava/return-same-error-value-from-spk_set_key_info/20170221-224753
config: i386-randconfig-x018-201708 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:13:0,
                    from drivers/staging/speakup/main.c:21:
   drivers/staging/speakup/main.c: In function 'spk_set_key_info':
>> include/linux/kern_levels.h:4:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/printk.h:136:11: note: in definition of macro 'no_printk'
       printk(fmt, ##__VA_ARGS__); \
              ^~~
   include/linux/kern_levels.h:14:20: note: in expansion of macro 'KERN_SOH'
    #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */
                       ^~~~~~~~
   include/linux/printk.h:330:12: note: in expansion of macro 'KERN_DEBUG'
     no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
               ^~~~~~~~~~
>> drivers/staging/speakup/main.c:1228:3: note: in expansion of macro 'pr_debug'
      pr_debug("key_data_len = %d, SHIFT_TBL_SIZE + 4 = %d,\t"
      ^~~~~~~~

vim +/pr_debug +1228 drivers/staging/speakup/main.c

  1212	{
  1213		int i = 0, states, key_data_len;
  1214		const u_char *cp = key_info;
  1215		u_char *cp1 = k_buffer;
  1216		u_char ch, version, num_keys;
  1217	
  1218		version = *cp++;
  1219		if (version != KEY_MAP_VER) {
  1220			pr_debug("version found %d should be %d\n",
  1221				 version, KEY_MAP_VER);
  1222			return -EINVAL;
  1223		}
  1224		num_keys = *cp;
  1225		states = (int)cp[1];
  1226		key_data_len = (states + 1) * (num_keys + 1);
  1227		if (key_data_len + SHIFT_TBL_SIZE + 4 >= sizeof(spk_key_buf)) {
> 1228			pr_debug("key_data_len = %d, SHIFT_TBL_SIZE + 4 = %d,\t"
  1229				 "sizeof(spk_key_buf) = %lu\n", key_data_len,
  1230				 SHIFT_TBL_SIZE + 4, sizeof(spk_key_buf));
  1231			return -EINVAL;
  1232		}
  1233		memset(k_buffer, 0, SHIFT_TBL_SIZE);
  1234		memset(spk_our_keys, 0, sizeof(spk_our_keys));
  1235		spk_shift_table = k_buffer;
  1236		spk_our_keys[0] = spk_shift_table;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27655 bytes)