linux-kernel - Re: [PATCH] uapi: fix linux/if.h userspace compilation errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170221.121022.676021611021776681.davem@davemloft.net>
Date:   Tue, 21 Feb 2017 12:10:22 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ldv@...linux.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uapi: fix linux/if.h userspace compilation errors

From: "Dmitry V. Levin" <ldv@...linux.org>
Date: Mon, 20 Feb 2017 14:58:41 +0300

> Include <sys/socket.h> (guarded by ifndef __KERNEL__) to fix
> the following linux/if.h userspace compilation errors:

Wouldn't it be so much better to do this in include/uapi/linux/socket.h?

I mean, look at the comment right by the change you are making:

> @@ -24,6 +24,10 @@
>  #include <linux/socket.h>		/* for "struct sockaddr" et al	*/
                                           ^^^^^^^^^^^^^^^^^^^^^^^

Anyone including linux/socket.h is trying to obtain that type.