linux-kernel - Re: [PATCH v3 4/5] vfs: Add timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Feb 2017 10:18:04 -0800
From:   Deepa Dinamani <deepa.kernel@...il.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, Alexander Viro <viro@...iv.linux.org.uk>,
        "Theodore Ts'o" <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        y2038 Mailman List <y2038@...ts.linaro.org>
Subject: Re: [PATCH v3 4/5] vfs: Add timestamp_truncate() api

>>> fs/inode.c:2125: warning: Excess function parameter 'gran' description in 'timestamp_truncate'
>   2116  /**
>   2117   * fs_timespec_trunc - Truncate timespec to a granularity
>   2118   * @t: Timespec
>   2119   * @gran: Granularity in ns.
>   2120   *
>   2121   * Truncate a timespec to a granularity. Always rounds down. gran must
>   2122   * not be 0 nor greater than a second (NSEC_PER_SEC, or 10^9 ns).
>   2123   */
>   2124  struct timespec timestamp_truncate(struct timespec t, struct inode *inode)
>> 2125  {
>   2126          struct super_block *sb = inode->i_sb;
>   2127          unsigned int gran = sb->s_time_gran;

This because the comment does not match the actual function signature:
The gran param mentioned in the comment is not actually part of
function signature.

I will fix the comment in the next version.

-Deepa