linux-kernel - Re: [PATCH] staging/ks7010: formatting updates.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Feb 2017 10:47:31 -0800
From:   Joe Perches <joe@...ches.com>
To:     Matthew Giassa <matthew@...ssa.net>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Wolfram Sang <wsa@...-dreams.de>,
        Greg KH <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        driverdevel <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] staging/ks7010: formatting updates.

On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote:
> * Geert Uytterhoeven <geert@...ux-m68k.org> [2017-02-21 15:22:10 +0100]:
> 
> > The first declaration fit nicely on a single line.
> > The second one indeed has a few spaces instead of TABs in the
> > continuation line. But that can be fixed easily, without moving the
> > first parameter to a continuation line.
> 
> What would the proposed fix be? A combination of spaces and hard-tabs? I
> don't see checkpatch complaining about it, so that could work too.

Maximal initial tabs, followed by required spaces to align
to open parenthesis

So from:

int ks_wlan_setup_parameter(struct ks_wlan_private *priv,
		             unsigned int commit_flag);

(2 tabs followed by 13 spaces)

to:

int ks_wlan_setup_parameter(struct ks_wlan_private *priv,
			    unsigned int commit_flag);

(3 tabs followed by 4 spaces)