linux-kernel - Re: [PATCH] staging/ks7010: formatting updates.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1487707366.2853.31.camel@perches.com>
Date:   Tue, 21 Feb 2017 12:02:46 -0800
From:   Joe Perches <joe@...ches.com>
To:     Matthew Giassa <matthew@...ssa.net>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        Greg KH <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        driverdevel <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] staging/ks7010: formatting updates.

On Tue, 2017-02-21 at 11:48 -0800, Matthew Giassa wrote:
> * Joe Perches <joe@...ches.com> [2017-02-21 10:47:31 -0800]:
> 
> > On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote:
> > > * Geert Uytterhoeven <geert@...ux-m68k.org> [2017-02-21 15:22:10 +0100]:
> > > 
> > > > The first declaration fit nicely on a single line.
> > > > The second one indeed has a few spaces instead of TABs in the
> > > > continuation line. But that can be fixed easily, without moving the
> > > > first parameter to a continuation line.
> > > 
> > > What would the proposed fix be? A combination of spaces and hard-tabs? I
> > > don't see checkpatch complaining about it, so that could work too.
> > 
> > Maximal initial tabs, followed by required spaces to align
> > to open parenthesis
> > 
> 
> Thank you Joe. I will change it accordingly. Is there a supplementary
> style guide that covers these finer details?

No, coding style just says

	Descendants are always substantially shorter than
	the parent and are placed substantially to the right

However alignment to the open parenthesis is a
pretty common style.