linux-kernel - Re: [PATCH] ALSA: usb-audio: constify snd_kcontrol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hpoibntc1.wl-tiwai@suse.de>
Date:   Tue, 21 Feb 2017 22:10:22 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Bhumika Goyal" <bhumirks@...il.com>
Cc:     <alsa-devel@...a-project.org>, <julia.lawall@...6.fr>,
        <perex@...ex.cz>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: constify snd_kcontrol_new structures

On Tue, 21 Feb 2017 21:03:27 +0100,
Bhumika Goyal wrote:
> 
> Declare snd_kcontrol_new structures as const as they are only passed as
> an argument to the function add_new_ctl. This agrument is of type const,
> so snd_kcontrol_new structures having this property can be made const
> too.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Well, this is again no urgent fix, so I'll postpone this to 4.12.

In general, please try to stop posting this kind of patches during the
merge window.  During the merge window, we concentrate only on the
stuff for the upcoming rc1, and receiving repeatedly non-urgent
cleanup patches is often just annoyance.

Of course, once after the merge window is closed, it's perfectly fine
to take such patches.


thanks,

Takashi


> ---
>  sound/usb/mixer_scarlett.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/sound/usb/mixer_scarlett.c b/sound/usb/mixer_scarlett.c
> index 7438e7c..c33e237 100644
> --- a/sound/usb/mixer_scarlett.c
> +++ b/sound/usb/mixer_scarlett.c
> @@ -477,7 +477,7 @@ static int scarlett_ctl_meter_get(struct snd_kcontrol *kctl,
>  	return 0;
>  }
>  
> -static struct snd_kcontrol_new usb_scarlett_ctl_switch = {
> +static const struct snd_kcontrol_new usb_scarlett_ctl_switch = {
>  	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
>  	.name = "",
>  	.info = scarlett_ctl_switch_info,
> @@ -487,7 +487,7 @@ static int scarlett_ctl_meter_get(struct snd_kcontrol *kctl,
>  
>  static const DECLARE_TLV_DB_SCALE(db_scale_scarlett_gain, -12800, 100, 0);
>  
> -static struct snd_kcontrol_new usb_scarlett_ctl = {
> +static const struct snd_kcontrol_new usb_scarlett_ctl = {
>  	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
>  	.access = SNDRV_CTL_ELEM_ACCESS_READWRITE |
>  		  SNDRV_CTL_ELEM_ACCESS_TLV_READ,
> @@ -499,7 +499,7 @@ static int scarlett_ctl_meter_get(struct snd_kcontrol *kctl,
>  	.tlv = { .p = db_scale_scarlett_gain }
>  };
>  
> -static struct snd_kcontrol_new usb_scarlett_ctl_master = {
> +static const struct snd_kcontrol_new usb_scarlett_ctl_master = {
>  	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
>  	.access = SNDRV_CTL_ELEM_ACCESS_READWRITE |
>  		  SNDRV_CTL_ELEM_ACCESS_TLV_READ,
> @@ -511,7 +511,7 @@ static int scarlett_ctl_meter_get(struct snd_kcontrol *kctl,
>  	.tlv = { .p = db_scale_scarlett_gain }
>  };
>  
> -static struct snd_kcontrol_new usb_scarlett_ctl_enum = {
> +static const struct snd_kcontrol_new usb_scarlett_ctl_enum = {
>  	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
>  	.name = "",
>  	.info = scarlett_ctl_enum_info,
> @@ -519,7 +519,7 @@ static int scarlett_ctl_meter_get(struct snd_kcontrol *kctl,
>  	.put =  scarlett_ctl_enum_put,
>  };
>  
> -static struct snd_kcontrol_new usb_scarlett_ctl_dynamic_enum = {
> +static const struct snd_kcontrol_new usb_scarlett_ctl_dynamic_enum = {
>  	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
>  	.name = "",
>  	.info = scarlett_ctl_enum_dynamic_info,
> @@ -527,7 +527,7 @@ static int scarlett_ctl_meter_get(struct snd_kcontrol *kctl,
>  	.put =  scarlett_ctl_enum_put,
>  };
>  
> -static struct snd_kcontrol_new usb_scarlett_ctl_sync = {
> +static const struct snd_kcontrol_new usb_scarlett_ctl_sync = {
>  	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
>  	.access = SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE,
>  	.name = "",
> -- 
> 1.9.1
> 
>