linux-kernel - Re: [PATCH] ALSA: x86: hdmi: select CONFIG_SND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hefyrnp61.wl-tiwai@suse.de>
Date:   Tue, 21 Feb 2017 23:40:22 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Arnd Bergmann" <arnd@...db.de>
Cc:     "Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        "Jerome Anand" <jerome.anand@...el.com>,
        "Pierre-Louis Bossart" <pierre-louis.bossart@...ux.intel.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: x86: hdmi: select CONFIG_SND_PCM

On Tue, 21 Feb 2017 23:02:37 +0100,
Arnd Bergmann wrote:
> 
> The newly added driver uses the PCM helpers and fails to link if they are disabled:
> 
> sound/built-in.o: In function `hdmi_lpe_audio_runtime_suspend':
> intel_hdmi_audio.c:(.text+0x15906): undefined reference to `snd_pcm_suspend'
> sound/built-in.o: In function `had_pcm_hw_params':
> intel_hdmi_audio.c:(.text+0x15ac7): undefined reference to `snd_pcm_lib_malloc_pages'
> sound/built-in.o: In function `had_pcm_open':
> intel_hdmi_audio.c:(.text+0x15d49): undefined reference to `snd_pcm_hw_constraint_integer'
> 
> This uses a Kconfig 'select' statement to make sure they are enabled.
> 
> Fixes: 5dab11d89777 ("ALSA: x86: hdmi: Add audio support for BYT and CHT")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks, applied.


Takashi