linux-kernel - Re: next-20170220 failed to build on PowerPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <8c472341719fe124b96de0f7cbfd1961@linux.vnet.ibm.com>
Date:   Tue, 21 Feb 2017 11:10:38 +0530
From:   Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
To:     fweisbec@...il.com
Cc:     linuxppc-dev@...ts.ozlabs.org, mpe@...erman.id,
        linux-kernel@...r.kernel.org, fbarrat@...ux.vnet.ibm.com,
        aneesh.kumar@...ux.vnet.ibm.com,
        Linuxppc-dev 
        <linuxppc-dev-bounces+abdhalee=linux.vnet.ibm.com@...ts.ozlabs.org>,
        abdul <abdhalee@...ux.vnet.ibm.com>
Subject: Re: next-20170220 failed to build on PowerPC

On 2017-02-20 16:25, abdul wrote:
> Hi,
> 
> next-20170220 fails to build on Power 8 (PowerVM LPAR) with these 
> errors.
> 
> with same config, next-20170215 builds fine.
> 
> the config file used is attached, by default
> CONFIG_VIRT_CPU_ACCOUNTING_NATIVE was not set.
> 
> (X) Simple tick based cputime accounting
> ( ) Deterministic task and CPU time accounting
> ( ) Full dynticks CPU time accounting
> 
> arch/powerpc/kernel/time.c: In function ‘running_clock’:
> arch/powerpc/kernel/time.c:712:25: error: implicit declaration of
> function ‘cputime_to_nsecs’
> [-Werror=implicit-function-declaration]
>    return local_clock() -
> cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
> 		  ^
> cc1: all warnings being treated as errors
> make[1]: *** [arch/powerpc/kernel/time.o] Error 1
> make[1]: *** Waiting for unfinished jobs....,
> 
> Note*: Problem is not seen when CONFIG_VIRT_CPU_ACCOUNTING_NATIVE is 
> enabled i.e
> 
> ( ) Simple tick based cputime accounting
> (X) Deterministic task and CPU time accounting
> ( ) Full dynticks CPU time accounting
> 

Bisecting resulted in below commit causing the build break.

commit f22d6df0b23e66b6d9058e2570402606a6ad069a
Author: Frederic Weisbecker <fweisbec@...il.com>
Date:   Tue Jan 31 04:09:43 2017 +0100

     sched/cputime: Remove jiffies based cputime

     This cputime_t implementation is now unused, we can remove it.

     Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
     Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
     Cc: Fenghua Yu <fenghua.yu@...el.com>
     Cc: Heiko Carstens <heiko.carstens@...ibm.com>
     Cc: Linus Torvalds <torvalds@...ux-foundation.org>
     Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
     Cc: Michael Ellerman <mpe@...erman.id.au>
     Cc: Paul Mackerras <paulus@...ba.org>
     Cc: Peter Zijlstra <peterz@...radead.org>
     Cc: Rik van Riel <riel@...hat.com>
     Cc: Stanislaw Gruszka <sgruszka@...hat.com>
     Cc: Thomas Gleixner <tglx@...utronix.de>
     Cc: Tony Luck <tony.luck@...el.com>
     Cc: Wanpeng Li <wanpeng.li@...mail.com>
     Link: 
http://lkml.kernel.org/r/1485832191-26889-28-git-send-email-fweisbec@gmail.com
     Signed-off-by: Ingo Molnar <mingo@...nel.org>


Regard's
Abdul Haleem
IBM Linux Technology Center.