linux-kernel - Re: [PATCH 1/2] drm/sti: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Feb 2017 10:04:12 +0100
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Vincent Abriou <vincent.abriou@...com>,
        David Airlie <airlied@...ux.ie>,
        Bich Hemon <bich.hemon@...com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] drm/sti: remove unused variable

2017-02-21 23:03 GMT+01:00 Arnd Bergmann <arnd@...db.de>:
> One variable was left behind after its user got removed and we should now
> delete the declaration as well:
>
> drivers/gpu/drm/sti/sti_vtg.c: In function 'vtg_probe':
> drivers/gpu/drm/sti/sti_vtg.c:392:22: error: unused variable 'np' [-Werror=unused-variable]
>
> Fixes: 0c7ff84f7f9d ("drm/sti: remove deprecated legacy vtg slave")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Hi Arnd,

Thanks for the patch but Vincent has send a patch for the both issues
issues a day ago :-)
https://lists.freedesktop.org/archives/dri-devel/2017-February/133346.html

Benjamin

> ---
>  drivers/gpu/drm/sti/sti_vtg.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
> index 943bce56692e..2dcba1d3a122 100644
> --- a/drivers/gpu/drm/sti/sti_vtg.c
> +++ b/drivers/gpu/drm/sti/sti_vtg.c
> @@ -389,7 +389,6 @@ static irqreturn_t vtg_irq(int irq, void *arg)
>  static int vtg_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
> -       struct device_node *np;
>         struct sti_vtg *vtg;
>         struct resource *res;
>         int ret;
> --
> 2.9.0
>



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog