linux-kernel - Re: [PATCH v2] Staging: comedi: drivers: comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e25d1fd-9475-48d4-e2b3-dc15b18cbf4e@mev.co.uk>
Date:   Wed, 22 Feb 2017 10:35:32 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Cheah Kok Cheong <thrust73@...il.com>,
        hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: comedi: drivers: comedi_test: Avoid multiple
 line dereference

On 21/02/17 17:25, Cheah Kok Cheong wrote:
> Fix checkpatch warning "Avoid multiple line dereference"
> using a pointer variable to avoid line wrap.
>
> Signed-off-by: Cheah Kok Cheong <thrust73@...il.com>
> ---
>
> V2:
> -Use pointer instead of normal variable - Ian
> -Variable is to be used as "write destination" and
>  not as "read source" - Ian
>
>  drivers/staging/comedi/drivers/comedi_test.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers/staging/comedi/drivers/comedi_test.c
> index 2a063f0..ccfd642 100644
> --- a/drivers/staging/comedi/drivers/comedi_test.c
> +++ b/drivers/staging/comedi/drivers/comedi_test.c
> @@ -480,11 +480,11 @@ static void waveform_ao_timer(unsigned long arg)
>  			/* output the last scan */
>  			for (i = 0; i < cmd->scan_end_arg; i++) {
>  				unsigned int chan = CR_CHAN(cmd->chanlist[i]);
> +				unsigned short *pd;
>
> -				if (comedi_buf_read_samples(s,
> -							    &devpriv->
> -							     ao_loopbacks[chan],
> -							    1) == 0) {
> +				pd = &devpriv->ao_loopbacks[chan];
> +
> +				if (!comedi_buf_read_samples(s, pd, 1)) {
>  					/* unexpected underrun! (cancelled?) */
>  					async->events |= COMEDI_CB_OVERFLOW;
>  					goto underrun;
>

Looks good, thanks!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-