linux-kernel - Re: [PATCH] ALSA: emu10k1: Remove cast from memory allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170222103759.GC30091@eros>
Date:   Wed, 22 Feb 2017 21:37:59 +1100
From:   "Tobin C. Harding" <me@...in.cc>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Jaroslav Kysela <perex@...ex.cz>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: emu10k1: Remove cast from memory allocation

On Wed, Feb 22, 2017 at 07:59:57AM +0100, Takashi Iwai wrote:
> On Wed, 22 Feb 2017 07:47:16 +0100,
> Tobin C. Harding wrote:
> > 
> > Coccinelle emits multiple WARNING: casting value returned by memory allocation
> > function to (u_int32_t __user *) is useless.
> > 
> > Remove unnecessary cast.
> > 
> > Signed-off-by: Tobin C. Harding <me@...in.cc>
> 
> __user annotation requires the explicit cast.

Ok, thanks for reviewing.

Tobin.

> 
> 
> Takashi
> 
> 
> > ---
> >  sound/pci/emu10k1/emufx.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c
> > index 56fc47b..8a39a6f 100644
> > --- a/sound/pci/emu10k1/emufx.c
> > +++ b/sound/pci/emu10k1/emufx.c
> > @@ -1186,8 +1186,8 @@ static int _snd_emu10k1_audigy_init_efx(struct snd_emu10k1 *emu)
> >  	if (!icode)
> >  		return err;
> >  
> > -	icode->gpr_map = (u_int32_t __user *) kcalloc(512 + 256 + 256 + 2 * 1024,
> > -						      sizeof(u_int32_t), GFP_KERNEL);
> > +	icode->gpr_map = kcalloc(512 + 256 + 256 + 2 * 1024,
> > +				sizeof(u_int32_t), GFP_KERNEL);
> >  	if (!icode->gpr_map)
> >  		goto __err_gpr;
> >  	controls = kcalloc(SND_EMU10K1_GPR_CONTROLS,
> > @@ -1824,8 +1824,8 @@ static int _snd_emu10k1_init_efx(struct snd_emu10k1 *emu)
> >  	if (!icode)
> >  		return err;
> >  
> > -	icode->gpr_map = (u_int32_t __user *) kcalloc(256 + 160 + 160 + 2 * 512,
> > -						      sizeof(u_int32_t), GFP_KERNEL);
> > +	icode->gpr_map = kcalloc(256 + 160 + 160 + 2 * 512,
> > +				sizeof(u_int32_t), GFP_KERNEL);
> >  	if (!icode->gpr_map)
> >  		goto __err_gpr;
> >  
> > -- 
> > 2.7.4
> > 
> > 

-- 
Tobin Harding
http://tobin.cc